dadonnelly316 commented on code in PR #50740: URL: https://github.com/apache/airflow/pull/50740#discussion_r2109355651
########## RELEASE_NOTES.rst: ########## @@ -741,7 +741,6 @@ Airflow 3.0 completes the migration of several core operators, sensors, and hook - ``PythonOperator`` - ``BashOperator`` - ``EmailOperator`` -- ``SimpleHttpOperator`` Review Comment: I have reviewed your feedback and took a closer look at the code. I'm not very familiar with Airflow's codebase but it looks like SimpleHttpOperator was part of the http provider prior to Airflow 3.0.0 release and flagged as deprecated, but was made importable from via add_deprecated_classes util from the __init__.py file in the Operators folder - https://github.com/apache/airflow/blob/d9ed7b94d033dc61ee1c05aafb9f1c1f7b82cfb2/airflow/operators/__init__.py#L97 https://github.com/apache/airflow/blob/d9ed7b94d033dc61ee1c05aafb9f1c1f7b82cfb2/airflow/utils/deprecation_tools.py#L66 It looks like the http provider removed the SimpleHttpOperator alongside the Airflow 3.0.0 release, and advised people to use the HttpOperator in the http provider. With this in mind, maybe I can add a bullet to the [deprecations & removals](https://airflow.apache.org/docs/apache-airflow/stable/release_notes.html#deprecations-removals) of the 3.0.0 release notes and specify that the deprecated SimpleHttpOperator was replaced with HttpOperator inside of the http provider and is no longer importable from airflow core. https://airflow.apache.org/docs/apache-airflow-providers-http/stable/changelog.html#breaking-changes But to your point that this should be explicitly stated in the release notes, maybe I can close out this PR with the above suggestions to avoid scope creep, and then take a deeper look into any other Operator that might've been importable from a provider within Airflow core and explicitly add those removed Operators to the release notes. Please let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
