Lee-W commented on code in PR #51133:
URL: https://github.com/apache/airflow/pull/51133#discussion_r2110614415
##########
.gitignore:
##########
@@ -116,6 +116,7 @@ celerybeat-schedule
# virtualenv
.venv*
venv*
+airflow_venv/
Review Comment:
Not sure we want to add it
```suggestion
```
##########
providers/standard/src/airflow/providers/standard/sensors/time_delta.py:
##########
@@ -52,16 +54,21 @@ class TimeDeltaSensor(BaseSensorOperator):
otherwise run_after will be used.
:param delta: time to wait before succeeding.
+ :param deferrable: Run sensor in deferrable mode. If set to True, task
will defer itself to avoid taking up a worker slot while it is waiting.
.. seealso::
For more information on how to use this sensor, take a look at the
guide:
:ref:`howto/operator:TimeDeltaSensor`
"""
- def __init__(self, *, delta, **kwargs):
+ def __init__(
+ self, *, delta: timedelta, deferrable: bool = False, end_from_trigger:
bool = False, **kwargs
Review Comment:
```suggestion
self,
*,
delta: timedelta,
deferrable: bool = conf.getboolean("operators",
"default_deferrable", fallback=False),
end_from_trigger: bool = False,
**kwargs,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
