hogan-tech opened a new pull request, #51161:
URL: https://github.com/apache/airflow/pull/51161
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
This PR fixes a UI bug in the Pools List page where the "Delete" (remove
filter) button for search filters was not fully visible. The issue was caused
by legacy table cell (`td`) settings in the template, which became problematic
after upgrading the Flask-AppBuilder package. The button was partially hidden,
with only its right border visible, making it difficult for users to remove
filters.
**What was changed:**
- Adjusted the table cell settings in `pool_list.html` to ensure the remove
filter button is always fully visible and accessible in the Pools List filter
UI.
## How to reproduce
1. Go to **Admin** → **Pools** in the Airflow UI (Admin tab → Pools button
in dropdown).
2. Click the **search filter** button.
3. Observe that the delete (remove filter) button is not fully visible (only
the right border shows).
## What you think should happen instead
The delete search filter button should be fully visible and easily clickable.
## Related PRs
- [Airflow: Add 'Show record' option for
variables](https://github.com/apache/airflow/pull/21342)
- [Flask-AppBuilder: fix: filter list UI spacing between
elements](https://github.com/dpgaspar/Flask-AppBuilder/pull/2128)
- [[2.x] Fix delete button visibility in search
filters](https://github.com/apache/airflow/pull/51100)
## Additional context
- This issue appeared after upgrading Flask-AppBuilder, which changed some
default table rendering behaviors.
- The fix is backward-compatible and only affects the Pools List page.
## Screenshots
**Before:**
<img width="1503" alt="Screenshot 2025-05-28 at 10 30 00 PM"
src="https://github.com/user-attachments/assets/cc5ade92-4ede-4841-b56f-422a2dbe76f1";
/>
**After:**
<img width="1494" alt="Screenshot 2025-05-28 at 10 30 40 PM"
src="https://github.com/user-attachments/assets/31ce99ff-dfe7-4de5-96e9-7468fc1e0d18";
/>
---
**Please review and let me know if further adjustments are needed.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
