bbovenzi commented on code in PR #51137:
URL: https://github.com/apache/airflow/pull/51137#discussion_r2112095423
##########
airflow-core/src/airflow/ui/src/layouts/Nav/SecurityButton.tsx:
##########
@@ -34,13 +36,13 @@ export const SecurityButton = () => {
return (
<Menu.Root positioning={{ placement: "right" }}>
<Menu.Trigger asChild>
- <NavButton icon={<FiLock size="1.75rem" />} title="Security" />
+ <NavButton icon={<FiLock size="1.75rem" />}
title={translate("nav.security")} />
</Menu.Trigger>
<Menu.Content>
{authLinks.extra_menu_items.map(({ text }) => (
<Menu.Item asChild key={text} value={text}>
<Link aria-label={text}
to={`security/${text.toLowerCase().replace(" ", "-")}`}>
- {text}
+ {translate(`security.${text.toLowerCase().replace(" ", "-")}`)}
Review Comment:
Let's make the security text into a variable so we're not transforming the
string twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
