jedcunningham commented on code in PR #50715:
URL: https://github.com/apache/airflow/pull/50715#discussion_r2114615500
##########
airflow-core/src/airflow/utils/log/log_reader.py:
##########
@@ -96,10 +99,17 @@ def read_log_stream(self, ti: TaskInstance, try_number: int
| None, metadata: di
TaskInstanceState.RUNNING,
TaskInstanceState.DEFERRED,
):
Review Comment:
I think it's the opposite actually - if its running, it hits the else block
here, then breaks out of the while loop. If the ti is running we _always_ break
out and do not do another iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]