vincbeck commented on code in PR #48872:
URL: https://github.com/apache/airflow/pull/48872#discussion_r2115984612
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -92,9 +89,19 @@ class RdsCreateDbSnapshotOperator(RdsBaseOperator):
:param tags: A dictionary of tags or a list of tags in format `[{"Key":
"...", "Value": "..."},]`
`USER Tagging
<https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_Tagging.html>`__
:param wait_for_completion: If True, waits for creation of the DB
snapshot to complete. (default: True)
+ :param aws_conn_id: The Airflow connection used for AWS credentials.
Review Comment:
Same, I think we should not include docstrings from parent classes. If there
are multiple parents, the list can become long and some docstring can quickly
become out of date. Another example: #51236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
