bbovenzi commented on code in PR #51239:
URL: https://github.com/apache/airflow/pull/51239#discussion_r2116070330
##########
airflow-core/src/airflow/ui/src/i18n/config.ts:
##########
@@ -39,12 +39,13 @@ import zhTWDashboard from "./locales/zh-TW/dashboard.json";
// import Backend from 'i18next-http-backend';
export const supportedLanguages = [
- { code: "de", name: "Deutsch" },
- { code: "en", name: "English" },
- { code: "ko", name: "한국어" },
- { code: "nl", name: "Nederlands" },
- { code: "pl", name: "Polski" },
- { code: "zh-TW", name: "繁體中文" },
+ { code: "de", name: "Deutsch", is_rtl: "No" },
+ { code: "en", name: "English", is_rtl: "No" },
+ { code: "he", name: "עברית", is_rtl: "Yes" },
+ { code: "ko", name: "한국어", is_rtl: "No" },
+ { code: "nl", name: "Nederlands", is_rtl: "No" },
+ { code: "pl", name: "Polski", is_rtl: "No" },
+ { code: "zh-TW", name: "繁體中文", is_rtl: "No" },
Review Comment:
I would prefer we use a real boolean value of `true` or `false` instead of
yes or no strings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
