amoghrajesh commented on code in PR #50117:
URL: https://github.com/apache/airflow/pull/50117#discussion_r2120257144
##########
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_xcoms.py:
##########
@@ -148,12 +149,12 @@ def test_xcom_access_denied(self, client, caplog):
},
id="-4",
),
- pytest.param(-3, 200, {"key": "xcom_1", "value": "f"}, id="-3"),
- pytest.param(-2, 200, {"key": "xcom_1", "value": "o"}, id="-2"),
- pytest.param(-1, 200, {"key": "xcom_1", "value": "b"}, id="-1"),
- pytest.param(0, 200, {"key": "xcom_1", "value": "f"}, id="0"),
- pytest.param(1, 200, {"key": "xcom_1", "value": "o"}, id="1"),
- pytest.param(2, 200, {"key": "xcom_1", "value": "b"}, id="2"),
Review Comment:
The newly added tests are rightly present. No need to change there.
The older tests
(https://github.com/apache/airflow/pull/50117/files#diff-5fb580f669f131661dde4f93ce870fc858935862892d0c751899c4e919001833L151-L156)
that tested the older version of the API -- from inception till `v2025_04_28`
will have to stay in
`core/tests/unit/api_fastapi/execution_api/versions/v2025_04_28/test_task_instances.py`.
You do not need to create a new `v2025_06_10` folder at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
