[ 
https://issues.apache.org/jira/browse/AIRFLOW-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960453#comment-16960453
 ] 

ASF GitHub Bot commented on AIRFLOW-5733:
-----------------------------------------

BasPH commented on pull request #6439: [AIRFLOW-5733] Migrate AWS components to 
/providers/aws [AIP-21]
URL: https://github.com/apache/airflow/pull/6439
 
 
   This PR moves all AWS components to `/providers/aws`, as described in 
[AIP-21](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths).
   
   Things to point out:
   
   - All old paths raise DeprecationWarnings
   - Components are now grouped by AWS service (`operators/s3.py` became quite 
long)
   - Had to fix test `TestS3ToGoogleCloudStorageOperator.test_execute` which 
was using the S3Hook from two different locations, which are now the same 
script. Other than that, no code changes, only moving.
   - Excluded full directory `'_api/airflow/providers/aws'` from the docs for 
now, a number of components are missing docs which should be handled in a 
different PR.
   
   Would be nice to get this merged quickly. Because of the large code change, 
it will be lots of work to keep up-to-date with master.
   
   -----------------
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5733
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Move all AWS components to its own submodule
> --------------------------------------------
>
>                 Key: AIRFLOW-5733
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5733
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws
>    Affects Versions: 2.0.0
>            Reporter: Bas Harenslak
>            Assignee: Bas Harenslak
>            Priority: Major
>
> As voted for in 
> [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths#AIP-21:Changesinimportpaths-Case#3\{aws/azure/gcp}_*],
>  and in similar fashion to all GCP components, which are now stored under 
> /airflow/gcp, we should move all AWS components to /airflow/aws.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to