jscheffl commented on code in PR #50192:
URL: https://github.com/apache/airflow/pull/50192#discussion_r2122005508
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -377,7 +379,21 @@ def create_pod(self, pod: V1Pod) -> V1Pod:
"""Launch the pod asynchronously."""
return self.run_pod_async(pod)
- def await_pod_start(
+ async def watch_pod_events(self, pod: V1Pod, check_interval: int = 1) ->
None:
+ """Read pod events and writes into log."""
+ self.keep_watching_for_events = True
+ num_events = 0
+ while self.keep_watching_for_events:
+ events = self.read_pod_events(pod)
+ for new_event in events.items[num_events:]:
+ involved_object: V1ObjectReference = new_event.involved_object
+ self.log.info(
+ "The Pod has an Event: %s from %s", new_event.message,
involved_object.field_path
+ )
+ num_events = len(events.items)
+ await asyncio.sleep(check_interval)
+
+ async def await_pod_start(
Review Comment:
I'd also prefer native async. Or @jason810496 what would be the benefit of a
"normal" function that is wrapped to async compared to directly implementing
async? Using async in sync is much easier in my view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
