[
https://issues.apache.org/jira/browse/AIRFLOW-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960505#comment-16960505
]
ASF GitHub Bot commented on AIRFLOW-5768:
-----------------------------------------
dstandish commented on pull request #6440: [AIRFLOW-5768] GCP cloud sql don't
store ephemeral connection in db
URL: https://github.com/apache/airflow/pull/6440
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-5768)
issues and references them in the PR title.
- https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-5768
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
GCP cloud sql operator creates dynamically an ephemeral Connection object.
It persists to metastore during execution and deletes afterward.
This behavior has negative impact on our ability to refactor creds
management.
By not persisting to database, we can also remove some complexity re
ensuring connection is deleted in event of failure, and the tests that go along
with that.
This change requires that we add optional param `connection` to both
MySqlHook and PostgresHook.
Incidentally, this PR incorporates test simplifications originally in
unmerged PR https://github.com/apache/airflow/pull/6390 and will render that PR
obsolete.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Google Cloud SQL - Don't store ephemeral connection object to database
> ----------------------------------------------------------------------
>
> Key: AIRFLOW-5768
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5768
> Project: Apache Airflow
> Issue Type: Improvement
> Components: gcp
> Affects Versions: 1.10.5
> Reporter: Daniel Standish
> Assignee: Daniel Standish
> Priority: Major
>
> GCP cloud sql operator creates dynamically an ephemeral Connection object.
> It persists to metastore during execution and deletes afterward.
> This behavior has negative impact on our ability to refactor creds
> management.
> By not persisting to database, we can also remove some complexity re ensuring
> connection is deleted in event of failure, and the tests that go along with
> that.
> This change requires that we add optional param `connection` to both
> MySqlHook and PostgresHook.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
