[
https://issues.apache.org/jira/browse/AIRFLOW-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960540#comment-16960540
]
ASF GitHub Bot commented on AIRFLOW-5769:
-----------------------------------------
mingrammer commented on pull request #6443: [AIRFLOW-5769] Rename the S3_hook
to s3_hook
URL: https://github.com/apache/airflow/pull/6443
Make sure you have checked _all_ steps below.
### Jira
- [] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
Of course, this update will lead to the API breaking change. Therefore, all
codes using `S3_hook` should change the import module names when this PR is
merged.
So if you agree with this change, it would be better to include these
updates in Airflow 2.0 rather than 1.x because it is kind of specification
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rename the S3_hook to s3_hook
> -----------------------------
>
> Key: AIRFLOW-5769
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5769
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 2.0.0
> Reporter: MinJae Kwon
> Assignee: MinJae Kwon
> Priority: Minor
> Fix For: 2.0.0
>
>
> All S3 related python files are using the "s3_" prefix, except only
> "S3_hook.py".
> It should be renamed to "s3_hook.py" (and also all import statements in
> dependant codes) for keeping naming consistency I think.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
