mingrammer commented on issue #6443: [AIRFLOW-5769] Rename the S3_hook to s3_hook URL: https://github.com/apache/airflow/pull/6443#issuecomment-546677862 @mik-laj I encountered a problem. Some file systems (including macOS's default one) are case-insensitive, so we can't have both `s3_hook.py` and `S3_hook.py`.simultaneously in those fs. So we should use another filename to separate that both. How do you think about that move the `s3_hook.py` to `contrib/hooks` like other AWS hooks (i.e. `aws_athena_hook`, `aws_lambda_hook` etc) named as `aws_s3_hook.py` (and change the class name to `class AWSS3Hook`)? And they (aws-*-hooks) look similar to each other. ```python class AWSAthenaHook(AwsHook): """ Interact with AWS Athena to run, poll queries and return query results :param aws_conn_id: aws connection to use. :type aws_conn_id: str :param sleep_time: Time to wait between two consecutive call to check query status on athena :type sleep_time: int """ INTERMEDIATE_STATES = ('QUEUED', 'RUNNING',) FAILURE_STATES = ('FAILED', 'CANCELLED',) SUCCESS_STATES = ('SUCCEEDED',) ... ``` ```python class S3Hook(AwsHook): """ Interact with AWS S3, using the boto3 library. """ def get_conn(self): return self.get_client_type('s3') ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
