sunank200 opened a new pull request, #51427:
URL: https://github.com/apache/airflow/pull/51427

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   `breeze --help` is throwing following in main branch:
   ```
   (airflow_venv_38) (base) sunank200@Ankits-Laptop airflow % breeze --help    
                                                                                
                                                                                
                                              
    Usage: breeze [OPTIONS] COMMAND [ARGS]...                                   
                                                                                
                                              
                                                                                
                                                                                
                                              
   Traceback (most recent call last):
     File "/Users/sunank200/Documents/airflow/airflow_venv_38/bin/breeze", line 
8, in <module>
       sys.exit(main())
                ^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 1442, in __call__
       return self.main(*args, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/rich_click/rich_command.py",
 line 125, in main
       with self.make_context(prog_name, args, **extra) as ctx:
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 1186, in make_context
       self.parse_args(ctx, args)
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 1786, in parse_args
       rest = super().parse_args(ctx, args)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 1197, in parse_args
       value, args = param.handle_parse_result(ctx, opts, args)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 2416, in handle_parse_result
       value = self.process_value(ctx, value)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 2355, in process_value
       value = self.callback(ctx, self, value)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/decorators.py",
 line 539, in show_help
       echo(ctx.get_help(), color=ctx.color)
            ^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 730, in get_help
       return self.command.get_help(self)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/click/core.py",
 line 1064, in get_help
       self.format_help(ctx, formatter)
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/rich_click/rich_command.py",
 line 166, in format_help
       rich_format_help(self, ctx, formatter)
     File 
"/Users/sunank200/Documents/airflow/airflow_venv_38/lib/python3.11/site-packages/rich_click/rich_click.py",
 line 551, in rich_format_help
       metavar_str = param.make_metavar()
                     ^^^^^^^^^^^^^^^^^^^^
   TypeError: Parameter.make_metavar() missing 1 required positional argument: 
'ctx'
   ```
   
   `rich-click==1.8.9` restores the old make_metavar(self) signature, so 
breeze’s existing calls to `param.make_metavar()` just work again.
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to