potiuk commented on code in PR #51329:
URL: https://github.com/apache/airflow/pull/51329#discussion_r2128628417
##########
.pre-commit-config.yaml:
##########
@@ -1267,6 +1268,14 @@ repos:
files:
^airflow-ctl/src/airflowctl/api/operations.py|airflow-ctl/src/airflowctl/cli/.*\.py$
additional_dependencies: ['rich>=12.4.4']
+ - id: go-mockery
+ name: Generate mocks for go
+ entry: --entrypoint ./scripts/in_container/run_mockery.sh
vektra/mockery:3
+ files: ^go-sdk/
Review Comment:
Do we want to always generate all mocks whenever any of the files in
`^go-sdk` ?
Not sure how fast it is, but one of the goals of the pre-commit is to make
things fast - but this one will run every time someone commits any go file in
`^go-sdk` (except mocks of course)
If we can add better selection this might be faster (but maybe not needed -
just pointing out potential optimization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
