potiuk commented on code in PR #51433:
URL: https://github.com/apache/airflow/pull/51433#discussion_r2128725457
##########
scripts/in_container/run_generate_constraints.py:
##########
@@ -349,10 +349,16 @@ def generate_constraints_pypi_providers(config_params:
ConfigParams) -> None:
# In case we have some problems with installing highest resolution of a
dependency of one of our
# providers in PyPI - we can exclude the buggy version here. For example
this happened with
- # sqlalchemy-spanner==1.4.0 which did not have `whl` file in PyPI and was
not installable
+ # sqlalchemy-spanner==1.12.0 which did not have `whl` file in PyPI and was
not installable
+ # and in this case we excluded it by adding ""sqlalchemy-spanner!=1.12.0"
to the list below.
+ # In case we add exclusion here we should always link to the issue in the
target dependency
+ # repository that tracks the problem with the dependency (we should create
one if it does not exist).
+ #
# Current exclusions:
- # * sqlalchemy-spanner:
https://github.com/googleapis/python-spanner-sqlalchemy/issues/682
- additional_constraints_for_highest_resolution =
["sqlalchemy-spanner!=1.12.0"]
Review Comment:
I added explicit example in comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
