andreas-thomik commented on issue #51429:
URL: https://github.com/apache/airflow/issues/51429#issuecomment-2948143483
The only place where `'container_name'` really gets used is here:
```python
def _get_logs_stream_name(self) -> str:
if (
self.awslogs_stream_prefix
and self.container_name
and not
self.awslogs_stream_prefix.endswith(f"/{self.container_name}")
):
return
f"{self.awslogs_stream_prefix}/{self.container_name}/{self._get_ecs_task_id(self.arn)}"
return
f"{self.awslogs_stream_prefix}/{self._get_ecs_task_id(self.arn)}"
```
Setting it to `None` in the event that the reponse doesn't return a valid
list of containers might lead to missing logs, but wouldn't fail the task as it
does at the moment. Maybe we could simply issue a warning if the
`awslogs_stream_prefix` does not contain at least a `/` **and** the list of
containers is empty? I'm concerned that polling for `ACTIVE` might take a long
time, especially when new EC2 instances have to be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
