jason810496 commented on code in PR #49470: URL: https://github.com/apache/airflow/pull/49470#discussion_r2135402447
########## airflow-core/src/airflow/utils/log/log_stream_counter.py: ########## @@ -0,0 +1,151 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import os +import tempfile +from typing import TYPE_CHECKING + +if TYPE_CHECKING: + from airflow.typing_compat import Self + from airflow.utils.log.file_task_handler import ( + LogHandlerOutputStream, + StructuredLogMessage, + StructuredLogStream, + ) + + +class LogStreamCounter: Review Comment: The only way to get the total log line is to iterating through the whole log stream. However, to make it memory efficient, we need to flush partial of logs to the temp file and also have the ability to replay the log stream after counting. This is the only purpose of this class, and I come out with LogStreamCount as name. Maybe LogStreamLineCounter is more comprehensible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
