guan404ming commented on PR #51531: URL: https://github.com/apache/airflow/pull/51531#issuecomment-2956527635
> But I am not **strongly** opposed - I just wonder how it fits in the "translation" process and how future translators will approach their tasks. > > The way how I imagine it is that they will do: `uv run ./check_translation_completness.py --language NEW_LANGUAGE --add-missing`. > > This will generate all the files with TODO: and we would expect the PR to only be merged where all TODO: are completed and things translated - the PR can be opened and iterated through multiple times, but It adds very little value if new language is "partially" added only. I can imagine that we should only accept new languages, when the person (or people) doing translation will show that they are able to do the job - and complete all currently needed translations rather than allow them to submit partial translations. I would very much prefer such translation to be a complete PR with all entries translated - because otherwise the person can disappear or burn out before all of it is done, which would mean we will have to remove it. > > So ... if that will be the process, then TODOs: in generated files indicate things to be done - and we could even improve the check_translation_completness.py script to count number of entries and number of TODO: left - to show progress in percentage, that the user will be able to run and see the progress. This is IMHO a bit better than having and issue that you need to manually update. It does make sense to me to make it a automated-todo gen instead of a issue need our manual update. Let me mark it as draft for now. I would re-open it if I have new idea about it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
