steinwaywhw commented on code in PR #49899:
URL: https://github.com/apache/airflow/pull/49899#discussion_r2136416311
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -168,34 +170,43 @@ def execute(self, context: Context):
ti.xcom_push(key="job_namespace", value=self.job.metadata.namespace)
self.pod: k8s.V1Pod | None
Review Comment:
this property seems to be internal to the KubernetesJobOperator itself. Is
that the case? If so does it make sense to remove it and only keep "self.pods"?
And also unify the cases where parallelism is None or 1 with parallelism > 1?
One point is that, even if parallelism is none or 1, it should still avoid
creating a pod. The K8s job will create the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
