romsharon98 commented on code in PR #51080:
URL: https://github.com/apache/airflow/pull/51080#discussion_r2136940830
##########
helm-tests/tests/helm_tests/security/test_scc_rolebinding.py:
##########
@@ -61,6 +61,29 @@ def test_create_scc(self, rbac_enabled, scc_enabled,
created):
assert jmespath.search("subjects[7].name", docs[0]) ==
"release-name-airflow-create-user-job"
assert jmespath.search("subjects[8].name", docs[0]) ==
"release-name-airflow-cleanup"
+ @pytest.mark.parametrize(
+ "dag_processor_enabled",
+ [
+ (True),
+ (False),
+ ],
+ )
+ def test_scc_subjects_include_dag_processor(self, dag_processor_enabled):
Review Comment:
Thanks for the explanation. I have two questions:
- Why do we need a separate test focusing on DagProcessor? What makes this
component more special than the others? In the end, it uses the same setup and
assertion as the tests above, so it seems like they could be combined.
- Why not just change the default value to False?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
