sunank200 commented on code in PR #51153:
URL: https://github.com/apache/airflow/pull/51153#discussion_r2137531383
##########
devel-common/src/sphinx_exts/docs_build/spelling_checks.py:
##########
@@ -71,17 +71,17 @@ def __lt__(self, other):
line_no_b: int = other.line_no or 0
context_line_a: str = self.context_line or ""
context_line_b: str = other.context_line or ""
- left: tuple[Path, int, int, str, str] = (
+ left: tuple[Path, int, str, str, str] = (
Review Comment:
`airflow‐core` docs build never actually hits the buggy sort, because there
are no real spelling errors (or only a single one, which never forces a
comparison). task-sdk build produces multiple spelling errors, one of which has
no context line, so the sort tries to compare a string to an integer and blows
up.
##########
devel-common/src/sphinx_exts/docs_build/spelling_checks.py:
##########
@@ -71,17 +71,17 @@ def __lt__(self, other):
line_no_b: int = other.line_no or 0
context_line_a: str = self.context_line or ""
context_line_b: str = other.context_line or ""
- left: tuple[Path, int, int, str, str] = (
+ left: tuple[Path, int, str, str, str] = (
Review Comment:
`airflow‐core` docs build never actually hits the buggy sort, because there
are no real spelling errors (or only a single one, which never forces a
comparison). `task-sdk` build produces multiple spelling errors, one of which
has no context line, so the sort tries to compare a string to an integer and
blows up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
