pierrejeambrun commented on code in PR #51534:
URL: https://github.com/apache/airflow/pull/51534#discussion_r2137911205
##########
airflow-core/src/airflow/ui/src/components/DagVersionSelect.tsx:
##########
@@ -35,18 +38,55 @@ type VersionSelected = {
export const DagVersionSelect = ({ showLabel = true }: { readonly showLabel?:
boolean }) => {
const { t: translate } = useTranslation("components");
- const { dagId = "" } = useParams();
+ const { dagId = "", runId } = useParams();
const { data, isLoading } = useDagVersionServiceGetDagVersions({ dagId,
orderBy: "-version_number" });
+
+ const { data: dagRunData } = useDagRunServiceGetDagRun(
+ {
+ dagId,
+ dagRunId: runId ?? "",
+ },
+ undefined,
+ { enabled: Boolean(dagId) && Boolean(runId) },
+ );
+
const [searchParams, setSearchParams] = useSearchParams();
const selectedVersionNumber = useSelectedVersion();
- const selectedVersion = data?.dag_versions.find((dv) => dv.version_number
=== selectedVersionNumber);
+
+ const availableVersions = useMemo(() => {
+ if (!data?.dag_versions) return [];
+
+ if (dagRunData?.dag_versions) {
+ const dagRunVersionNumbers = new Set(
+ dagRunData.dag_versions.map((v: DagVersionResponse) =>
v.version_number)
+ );
Review Comment:
You do not need a set. The backend is taking care of returning the unique
versions list involved in the DagRun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
