notatallshaw commented on issue #6370: AIRFLOW-5701: Don't clear xcom 
explicitly before execution
URL: https://github.com/apache/airflow/pull/6370#issuecomment-546726723
 
 
   > First of all, you should be able to just serialize the execution_date. 
Instead of converting it to a string, and parse it again.
   
   Unless I switch a pickle flag it complains that it is not JSON serializable, 
the comments in the code indicate pickling is going away for for Airflow 2.0. 
I'm trying to ease my migration ahead of time :).
   
    > I don't think your example is complete. 
   
   Correct, as stated it's a proof of concept to show different behavior 
between the current state and the PR it is not designed to be an actual 
Operator.
   
   > So I'm thinking of making this configurable. By adding an option to the 
`xcom_pull`, for example, `include_self` (working name), which implies that it 
will also include earlier xcom's of itself.
   
   At least for me this would be extremely helpful! I have workflows that would 
use `include_self` set to True and others that would use it set to False. It is 
also far more semantically clear what behavior is happening, which as best as I 
can tell you can only currently figure out from either experimentation or 
reading the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to