louisguitton edited a comment on issue #6445: [AIRFLOW-5735][AIP-21] Move 
airflow.contrib.operators.s3_to_gcs_operator to core
URL: https://github.com/apache/airflow/pull/6445#issuecomment-546715506
 
 
   Hey @BasPH , good point. As I can read: 
   
   > In case of transfer operators where two providers are involved, the 
transfer operators will be moved to "source" of the transfer. 
   
   Meaning in this case AWS indeed.
   3 remarks from my point of view:
   
   1. I was picking up the Jira ticket only, so if those are pretty flexible 
and we can change the scope mid-way no worries for me
   2. I was not planning to tackle all aspects of AIP-21 in that PR (again just 
focussing on the Jira ticket): for example you could treat this operator for 
both `case 1` and `case 2`, but I was leaving `case 2` out of the scope of this 
PR. If it makes more sense to tackle both at the same time, let me know,
   3. In the case of s3 to gcs there are 2 operators doing the job 
`s3_to_gcs_operator` and `s3_to_gcs_transfer_operator`. According to the quote 
above, they should both end up in `providers/aws` but in the case of 
`s3_to_gcs_transfer_operator`, it actually uses a gcp service under the hood 
and arguably could end up in `providers/google/gcp` 😅  . Is that rule of 
"source to destination" suppose to prevail anyway ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to