kaxil commented on code in PR #51695: URL: https://github.com/apache/airflow/pull/51695#discussion_r2149817377
########## providers/standard/src/airflow/providers/standard/triggers/interactive.py: ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import asyncio +from collections.abc import AsyncIterator +from typing import Any, TypedDict + +from airflow.triggers.base import BaseTrigger, TriggerEvent + + +class _InteractiveResponseTriggerEventPaylod(TypedDict): + content: str + + +class _InteractiveMultipleResponseTriggerEventPaylod(TypedDict): + content: list[str] + + +class InteractiveTrigger(BaseTrigger): + """AIP-90 Tirggerer.""" + + def __init__( + self, + *, + ti_id, + options: list[str], + default: str | None = None, + multiple: bool = False, + poke_interval: float = 5.0, + **kwargs, + ): + super().__init__() + self.ti_id = ti_id + self.options = options + self.default = default + self.multiple = multiple + self.poke_interval = poke_interval + + def serialize(self) -> tuple[str, dict[str, Any]]: + """Serialize InteractiveTrigger arguments and classpath.""" + return ( + "airflow.providers.standard.triggers.interactive.InteractiveTrigger", + { + "ti_id": self.ti_id, + "options": self.options, + "default": self.options, + "multiple": self.multiple, + "poke_interval": self.poke_interval, + }, + ) + + async def run(self) -> AsyncIterator[TriggerEvent]: + """Loop until the relevant files are found.""" + while True: + # TODO: check whether the InteractiveResponseModel row for ti is created Review Comment: I think Custom routes should be in Exec API for now since we won't be able to limit access to certain variables, connections, etc. for Task in Public API (at least not now), whereas we have the correct hook points already on the Execution API. And during ~AF 3.2 or 3.3+ timeframe, we could add a way for Task to use Public API -- which does mean code duplication for now, but that is probably fine since otherwise we would have to possibly generate all Public API models on Task SDK side (or use [Python Client](https://github.com/apache/airflow-client-python) potentially ?) which is more work right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
