amoghrajesh commented on code in PR #51699:
URL: https://github.com/apache/airflow/pull/51699#discussion_r2151484708
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -266,20 +263,18 @@ def _on_child_started(
msg = DagFileParseRequest(
file=os.fspath(path),
bundle_path=bundle_path,
- requests_fd=self._requests_fd,
callback_requests=callbacks,
)
- self.send_msg(msg)
+ self.send_msg(msg, request_id=0)
- def _handle_request(self, msg: ToManager, log: FilteringBoundLogger) ->
None: # type: ignore[override]
+ def _handle_request(self, msg: ToManager, log: FilteringBoundLogger,
req_id: int) -> None: # type: ignore[override]
from airflow.sdk.api.datamodels._generated import ConnectionResponse,
VariableResponse
resp: BaseModel | None = None
dump_opts = {}
if isinstance(msg, DagFileParsingResult):
self.parsing_result = msg
- return
- if isinstance(msg, GetConnection):
+ elif isinstance(msg, GetConnection):
Review Comment:
Good qn, i wonder it it will raise an error here:
https://github.com/apache/airflow/pull/51699/files#diff-c076ff9d88eb776c2f874ea4fbb66c9d090e080ed5c9b80c2c36dcb3a51360d3R228-R230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
