potiuk commented on issue #51545: URL: https://github.com/apache/airflow/issues/51545#issuecomment-2979451000
Yes. I think there are far too many things that we share that we cannot avoid `common` package. Moreover we should invest to make it in the way that it consists of loose collection of independent things that do not depend on each other - for example we should unentangle all the conf + settings circular depedencies that we have currently. While I understand being `averse` of all kinds of common/util things. I believe that if they are done right and they are: * small * "low layer" (i.e. they are only used by core they never use anything else from the "utils" or other parts of the code). * separated * not dependending on each other Moreover with `uv workspace` - we can actually enforce most of that. Simply "common" package should be at the "bottom" - i.e. "core" and "sdk" and whatever else needs it should have it as workspace dependency, but it should have a dependency on other parts of the system Then - if we follow what I've implemented for all the other packages - if that common distribution has it's own tests - they will be executed after `uv sync` run in "common" - which means that no other distributions will be installed when running the tests, this is the enforcement we need so that no other circular dependencies, or otherwise depending on "stuff" from core in the "common" package is not happening. This has been my proposal from the beginning on the discussion and it has not changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
