choo121600 commented on code in PR #51735:
URL: https://github.com/apache/airflow/pull/51735#discussion_r2153200580
##########
airflow-core/src/airflow/ui/eslint.config.js:
##########
@@ -35,8 +35,9 @@ import { unicornRules } from "./rules/unicorn.js";
* @see [ESLint configuration](https://eslint.org/docs/latest/use/configure/)
*/
export default /** @type {const} @satisfies {ReadonlyArray<FlatConfig.Config>}
*/ ([
+ i18nRules,
// Global ignore of dist directory
- { ignores: ["**/dist/", "**coverage/"] },
+ { ignores: ["**/dist/", "**coverage/", "public/i18n/locales/**/*.json"] },
Review Comment:
That makes sense. I had previously made the change due to a pre-commit
issue, but it should be okay to revert it . I'll update it accordingly.
##########
airflow-core/src/airflow/ui/public/i18n/README.md:
##########
@@ -177,7 +177,7 @@ Translation conflicts MUST be resolved according to the
procedures outlined in s
The following steps outline the process for approving a new locale to be added
to the supported locales:
- Creating a PR for adding the suggested locale to the codebase ([see
example](https://github.com/apache/airflow/pull/51258/files)), which includes:
- - The locale files (translated according to the guidelines) in the
`airflow-core/src/airflow/ui/src/i18n/locales/<LOCALE_CODE>` directory, where
`<LOCALE_CODE>` is the code of the language according to ISO 639-1 standard
(e.g., `fr` for French). Languages with regional variants should be handled in
separate directories, where the name is suffixed with `-<VARIANT>`, and
`<VARIANT>` is the variant that follows ISO 3166-1 or UN M.49 codes in
lowercase (e.g., `zh-tw` for Taiwanese Mandarin).
+ - The locale files (translated according to the guidelines) in the
`airflow-core/src/airflow/ui/public/i18n/locales/<LOCALE_CODE>` directory,
where `<LOCALE_CODE>` is the code of the language according to ISO 639-1
standard (e.g., `fr` for French). Languages with regional variants should be
handled in separate directories, where the name is suffixed with `-<VARIANT>`,
and `<VARIANT>` is the variant that follows ISO 3166-1 or UN M.49 codes in
lowercase (e.g., `zh-tw` for Taiwanese Mandarin).
- Making the required modifications in
`airflow-core/src/airflow/ui/src/i18n/config.ts` ([see
example](https://github.com/apache/airflow/pull/51258/files#diff-bfb4d5fafd26d206fb4a545a41ba303f33d15a479d21e0a726fd743bdf9717ff)).
Review Comment:
The config.ts file is originally located at
airflow-core/src/airflow/ui/src/i18n/config.ts, so it is indeed under src/i18n.
Therefore, the path is correct and does not need to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
