ashb commented on code in PR #51873: URL: https://github.com/apache/airflow/pull/51873#discussion_r2153926207
########## airflow-core/src/airflow/cli/commands/connection_command.py: ########## @@ -33,9 +33,9 @@ from airflow.cli.utils import is_stdout, print_export_output from airflow.configuration import conf from airflow.exceptions import AirflowNotFoundException -from airflow.hooks.base import BaseHook from airflow.models import Connection from airflow.providers_manager import ProvidersManager +from airflow.sdk import BaseHook Review Comment: Is Thors only needed for test conn? If so can we delay the import to the fn, and handle it missing with a nice error message? ########## providers/airbyte/src/airflow/providers/airbyte/hooks/airbyte.py: ########## @@ -26,7 +26,7 @@ from requests import Session from airflow.exceptions import AirflowException -from airflow.hooks.base import BaseHook +from airflow.sdk import BaseHook Review Comment: All these will need a try/except so they continue to work on Airflow 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
