seanghaeli commented on code in PR #51719:
URL: https://github.com/apache/airflow/pull/51719#discussion_r2155398885
##########
providers/amazon/tests/system/amazon/aws/example_mwaa.py:
##########
@@ -66,6 +66,22 @@ def unpause_dag(env_name: str, dag_id: str):
return not response["RestApiResponse"]["is_paused"]
+# Can only be run after 'trigger_dag_run' task is run.
+@task
+def get_task_id(env_name: str, dag_id: str):
Review Comment:
I'm not certain it would make sense. Take the current test case as an
example:
1. The DAG name is passed in externally through `EXISTING_DAG_ID_KEY`.
2. `MwaaTriggerDagRunOperator` triggers a DAG Run.
3. An API call is made within the `get_task_id` function to find the task
IDs within the above DAG Run.
If the DAG Run ID is not pased in externally, I'm not sure it makes sense
for the Task instance ID to be. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
