PNL0 commented on code in PR #51264: URL: https://github.com/apache/airflow/pull/51264#discussion_r2155490842
########## airflow-core/src/airflow/ui/src/pages/Dashboard/FavoriteDags/FavoriteDags.tsx: ########## @@ -0,0 +1,96 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, Flex, Heading, SimpleGrid, Text } from "@chakra-ui/react"; +import { useQueryClient } from "@tanstack/react-query"; +import { useEffect, useMemo, useState } from "react"; +import { useTranslation } from "react-i18next"; +import { FiStar } from "react-icons/fi"; +import { useLocation } from "react-router-dom"; + +import { useDagServiceGetDags } from "openapi/queries"; + +import { FavoriteDagCard } from "./FavoriteDagCard"; + +const MAX_VISIBLE = 5; + +export const FavoriteDags = () => { + const queryClient = useQueryClient(); + const location = useLocation(); + + const { t: translate } = useTranslation("dashboard"); + const { data: favorites } = useDagServiceGetDags({ favorites: true }); Review Comment: > The rest of the UI is using `useDagServiceGetDagsUi` to fetch dags. The UI should probably only use this, and we should also update the `ui/get_dags` endpoint to be able to do the same filtering on favorites. (therefore a common `parameters.py` will be helpful) Currently working on this. I will submit in the next few days another commit with the necessary changes (it will probably involve a rebase, since I don't have the **useDagServiceGetDagsUi** implemented in my local version). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
