Nataneljpwd commented on code in PR #51893:
URL: https://github.com/apache/airflow/pull/51893#discussion_r2156140409
##########
providers/http/src/airflow/providers/http/hooks/http.py:
##########
@@ -159,8 +174,14 @@ def get_conn(
connection = self.get_connection(self.http_conn_id)
self._set_base_url(connection)
session = self._configure_session_from_auth(session, connection)
+
+ # Since get_conn can be called outside of run, we'll check this again
+ extra_options = extra_options or {}
+
if connection.extra or extra_options:
Review Comment:
Ok, though I still did not understand why can't the configure function be
called all the time regardless of whether extra options exist as it won't
modify the session if there are no options, but it is not too important, so you
may mark it as resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
