Lee-W commented on code in PR #51759:
URL: https://github.com/apache/airflow/pull/51759#discussion_r2156508271
##########
providers/weaviate/src/airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -128,9 +128,16 @@ def get_conn(self) -> WeaviateClient:
extras = conn.extra_dejson
http_secure = extras.pop("http_secure", False)
grpc_secure = extras.pop("grpc_secure", False)
+ http_port = extras.get("http_port", conn.port or (443 if http_secure
else 80))
+ self.log.debug(
+ "Connecting to Weaviate with: http_host=%s, http_port=%s,
http_secure=%s",
+ conn.host,
+ http_port,
+ http_secure,
+ )
return weaviate.connect_to_custom(
http_host=conn.host,
- http_port=conn.port or 443 if http_secure else 80,
+ http_port=extras.get("http_port", conn.port or (443 if http_secure
else 80)),
Review Comment:
should we just reuse `http_port`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
