bugraoz93 commented on code in PR #51657: URL: https://github.com/apache/airflow/pull/51657#discussion_r2159425837
########## providers/keycloak/src/airflow/providers/keycloak/auth_manager/middleware.py: ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING, Any +from urllib.parse import urlencode + +from jwt import ExpiredSignatureError, InvalidTokenError +from starlette.middleware.base import BaseHTTPMiddleware + +from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN +from airflow.configuration import conf + +if TYPE_CHECKING: + from fastapi import Request + + +class KeycloakRefreshTokenMiddleware(BaseHTTPMiddleware): + """Middleware that automatically refreshes the Keycloak token if it is expired.""" + + def __init__(self, app: Any, auth_manager: Any) -> None: + """ + Initialize the middleware with app and auth manager. + + :param app: The FastAPI application + :param auth_manager: The KeycloakAuthManager instance + """ + super().__init__(app) + self.auth_manager = auth_manager + + async def dispatch(self, request: Request, call_next): + """Refresh the token if it is expired.""" + try: + return await call_next(request) + except (InvalidTokenError, ExpiredSignatureError): + code = None + if "code" in request.query_params: Review Comment: Thanks a lot for your time! This is not working because the code coming is different. Also, only auth requests end up in this middleware, which makes it impossible to cover each cases. This is a middle state of the code. I tested multiple times. It was really hard and problematic to do this in KeycloakMiddleware. I tried multiple ways in a couple of days this week. Nothing worked because I couldn't properly get the cureent user. I will move the middleware to Core Airlow. I will try to finilise it today or tomorrow. There is one thing, though I tested multiple times with Keycloak and see that after the token expires internal one, UI automatically calls the login and refreshes the token. I have tested via default to 10 seconds expiration. Without these changes, UI refreshing the token, the only thing is it fallbacks to the home page of Airflow. If we want to fall back to the same page rather than the homepage, that could indeed be done in core Airflow middleware. Of course, if the Keycloak session expires, login is needed. So I am thinking maybe this refresh token is not needed after all. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
