sunank200 commented on code in PR #51956:
URL: https://github.com/apache/airflow/pull/51956#discussion_r2159383147
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -268,8 +268,19 @@ def get_or_create_spark_crd(self, launcher:
CustomObjectLauncher, context) -> k8
def process_pod_deletion(self, pod, *, reraise=True):
if pod is not None:
if self.delete_on_termination:
- self.log.info("Deleting spark job: %s",
pod.metadata.name.replace("-driver", ""))
-
self.launcher.delete_spark_job(pod.metadata.name.replace("-driver", ""))
+ pod_name = pod.metadata.name.replace("-driver", "")
+ self.log.info("Deleting spark job: %s", pod_name)
+
+ # because of self.launcher is defined in execute method it
does not exist for
Review Comment:
Why not create a setter for self.luncher on class level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
