KevinYang21 commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly 
before execution
URL: https://github.com/apache/airflow/pull/6370#issuecomment-547248960
 
 
   Hi @Fokko,
   
   Sry I'm late again. Read all the discussion and history but I have to say 
I'm not really a big fan of this approach. XCOM was designed for inter-task 
communication and should stay in that way. Reusing it for inside-task 
communication may just mix up these two purposes and introduce a maintainance 
headache. And we've already started to see a bit of that through the 
`include_prior_dates` case, yes we have a work around for that but to me that 
is a bit hacky and a start of more confusion. Similarly [the case from 
Sid](https://github.com/apache/airflow/pull/1180#issuecomment-199526302). Bolke 
got a good point, idempotence needs to be guaranteed and I think the original 
way of clearing the XCOM is actually a pretty good way to ensure that.
   
   That's not saying I'm against the idea behind it: having inside-task 
communication I think is important and can enable a lot more possibility. And I 
like the atomic change in this PR. But IMO there need to be something else that 
we use to approach the inside-task communication issue--tho maybe a bit more 
complicated but purer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to