uranusjr commented on code in PR #51638:
URL: https://github.com/apache/airflow/pull/51638#discussion_r2160800660
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1769,6 +1770,25 @@ def _update_state(dag: DAG, dag_run: DagRun):
_update_state(dag, dag_run)
dag_run.notify_dagrun_state_changed()
+ if (deadline := dag.deadline) and isinstance(
+ deadline.reference, ReferenceModels.DagRunQueuedAtDeadline
+ ):
Review Comment:
Would it be a good idea to add a `get_dagrun_queued_at_deadline` on DAG like
the creation deadline? Or remove the function for the creation deadline? It
seems weird one has a function and one does not.
If this feels repetitive, maybe the function should be changed to like
`get_deadline(kind: type[T]) -> T`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
