Lee-W commented on code in PR #49470:
URL: https://github.com/apache/airflow/pull/49470#discussion_r2160924178
##########
airflow-core/src/airflow/utils/log/log_reader.py:
##########
@@ -91,24 +92,19 @@ def read_log_stream(
try_number = ti.try_number
for key in ("end_of_log", "max_offset", "offset", "log_pos"):
- metadata.pop(key, None)
+ #
https://mypy.readthedocs.io/en/stable/typed_dict.html#supported-operations
+ metadata.pop(key, None) # type: ignore[misc]
empty_iterations = 0
while True:
- logs, out_metadata = self.read_log_chunks(ti, try_number, metadata)
- # Update the metadata dict in place so caller can get new
values/end-of-log etc.
-
- for log in logs:
- # It's a bit wasteful here to parse the JSON then dump it back
again.
- # Optimize this so in stream mode we can just pass logs right
through, or even better add
- # support to 307 redirect to a signed URL etc.
Review Comment:
sounds good. just want to confirm it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
