uranusjr commented on code in PR #50990:
URL: https://github.com/apache/airflow/pull/50990#discussion_r2160696915
##########
airflow-core/tests/unit/utils/test_log_handlers.py:
##########
@@ -106,10 +105,10 @@ def test_default_task_logging_setup(self):
handler = handlers[0]
assert handler.name == FILE_TASK_HANDLER
- @pytest.mark.xfail(reason="TODO: Needs to be ported over to the new
structlog based logging")
def test_file_task_handler_when_ti_value_is_invalid(self, dag_maker):
- def task_callable(ti):
- ti.log.info("test")
+ def task_callable():
+ logger = logging.getLogger(TASK_LOGGER)
Review Comment:
Should this use structlog.get_logger instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
