pierrejeambrun commented on code in PR #51889:
URL: https://github.com/apache/airflow/pull/51889#discussion_r2162003999
##########
airflow-core/tests/unit/plugins/test_plugin.py:
##########
@@ -102,12 +102,14 @@ async def dispatch(self, request, call_next):
"name": "Name of the Middleware",
}
-iframe_view_with_metadata = {
+external_view_with_metadata = {
"name": "Test IFrame Plugin",
- "src": "https://www.google.com";,
+ "href": "https://www.google.com";,
"icon": "https://example.com/icon.svg";,
- "url_route": "/test_iframe_plugin",
+ "dark_mode_icon": "https://example.com/dark_icon.svg";,
+ "url_route": "test_iframe_plugin",
"destination": "nav",
+ "category": "browse",
}
Review Comment:
You're right, that's a good point, thanks Jens, I think all of those
reference to google were in 'tests' but that dosn't cost much to remove the
ambiguity and use Airflow Docs framing. I'll update the example to reference
dirrectly that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://example.com/icon.svg"](https://example.com/icon.svg"){kind=link}
![https://example.com/dark_icon.svg"](https://example.com/dark_icon.svg"){kind=link}