mik-laj commented on a change in pull request #5694: [AIRFLOW-5082] add subject
in aws sns hook
URL: https://github.com/apache/airflow/pull/5694#discussion_r340268321
##########
File path: airflow/contrib/hooks/aws_sns_hook.py
##########
@@ -53,8 +55,16 @@ def publish_to_target(self, target_arn, message):
'default': message
}
+ if subject is None:
Review comment:
So we don't need one additional "If" instruction in the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
