harikrishna12524 opened a new pull request, #52124:
URL: https://github.com/apache/airflow/pull/52124
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**Added support for regional secrets in google secret manager**
Google secret provider was lacking support for storing regional secrets
which was supported by Google Cloud Secrets, changes were made to add this
functionality.
Changes :
- Added a constructor for taking `location_id` optional property.
- Changes `client` getter to initialize `SecretManagerServiceClient` based
on whether `location_id` is provided or not.
- Added methods `_get_parent`, `_get_secret_path` and
`_get_secret_version_path` as helper methods to build the path with or without
`location_id` based on parameters.
- Added `location_id` parameter to methods `create_secret`,
`add_secret_version`, `list_secrets`, `secret_exists`, `access_secret` and
`delete_secret` for handling regional secrets.
closes: #49709
This is my first commit, so I am unsure if my approaches for the changes are
correct. So, I haven't changes the tests completely. Please review my approach
once, and I will make required changes to the provider and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
