ashb commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect 
naming for scheduler used slot metric
URL: https://github.com/apache/airflow/pull/6342#discussion_r340530430
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -982,10 +982,13 @@ def _find_executable_task_instances(self, 
simple_dag_bag, states, session=None):
 
             
Stats.gauge('pool.starving_tasks.{pool_name}'.format(pool_name=pool_name),
                         num_starving_tasks)
+            slots_stats = pools[pool_name].slots_stats()
             
Stats.gauge('pool.open_slots.{pool_name}'.format(pool_name=pool_name),
-                        pools[pool_name].open_slots())
+                        slots_stats["open"])
 
 Review comment:
   Yes, I think we haven't yet updated the DB with the new pool usages yet, so 
the DB value won't be correct. I think. Are you able to confirm or deny this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to