potiuk commented on code in PR #47719:
URL: https://github.com/apache/airflow/pull/47719#discussion_r2174658462
##########
providers/http/src/airflow/providers/http/triggers/http.py:
##########
@@ -185,15 +185,21 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
while True:
try:
async with aiohttp.ClientSession() as session:
- await hook.run(
+ client_response = await hook.run(
session=session,
endpoint=self.endpoint,
data=self.data,
headers=self.headers,
extra_options=self.extra_options,
)
- yield TriggerEvent(True)
- return
+ response = await
HttpTrigger._convert_response(client_response)
+ yield TriggerEvent(
+ {
+ "status": "success",
+ "response":
base64.standard_b64encode(pickle.dumps(response)).decode("ascii"),
Review Comment:
We should rather use our own serialization - and only one mechanism if
possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
