bbovenzi commented on code in PR #52403:
URL: https://github.com/apache/airflow/pull/52403#discussion_r2175143965


##########
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionForm.tsx:
##########
@@ -94,6 +94,14 @@ const ConnectionForm = ({
     mutateConnection(data);
   };
 
+  const hasChanges = () => {

Review Comment:
   Nit. functions should start with a verb.
   
   But we don't even need a function here.
   
   `const hasChanges = isDirty ?? JSON.stringify(JSON.parse(extra)) !== 
JSON.stringify(JSON.parse(initialConnection.extra))`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to