dstandish commented on a change in pull request #5787: [AIRFLOW-5172] Add
choice of interval edge scheduling
URL: https://github.com/apache/airflow/pull/5787#discussion_r340744386
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -648,7 +648,7 @@ def create_dag_run(self, dag, session=None):
if dag.schedule_interval == '@once':
period_end = next_run_date
elif next_run_date:
- period_end = dag.following_schedule(next_run_date)
+ period_end = dag.period_end(next_run_date)
Review comment:
Yeah i'm not saying you are responsible for all confusing naming, just
suggesting not to add to it ;)
`period_end` is a new function.
And I don't think it would be out of scope to change the local `period_end`
variables either since you are in effect changing their meaning in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
