jscheffl commented on code in PR #51738:
URL: https://github.com/apache/airflow/pull/51738#discussion_r2175886856
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -159,6 +159,10 @@ class DagRun(Base, LoggingMixin):
triggered_by = Column(
Enum(DagRunTriggeredByType, native_enum=False, length=50)
) # Airflow component that triggered the run.
+ triggering_user = Column(
+ String(512),
+ nullable=True,
+ ) # The user that triggered the DagRun, if applicable
Review Comment:
Yes, would be a foreign kwy if we have a reliable user base. But the user
tables are only used when running with FAB, else they probably are not existing
or empty. Therefore I decided to storage the name just as literal w/o
constraint.
Otherwise as well even if FAB is used probably also we don't want to CASCADE
a user deletion to delete all user specific DAG runs and as well we don't want
to block user deletion just because the user had triggered a DAG in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
