kyungjunleeme commented on code in PR #52388:
URL: https://github.com/apache/airflow/pull/52388#discussion_r2176299771
##########
chart/templates/_helpers.yaml:
##########
@@ -216,6 +216,34 @@ If release name contains chart name it will be used as a
full name.
defaultMode: 288
{{- end }}
+{{/* Helper to render git-sync credentials envs for v3/v4 */}}
+{{- define "git_sync.env_credentials" }}
+{{- $tag := .Values.images.gitSync.tag | default "v4" }}
Review Comment:
@jedcunningham
Thank you so much for pointing this out — I had completely overlooked all of
these important aspects.
Regarding the following part:
Also, we will want a significant newsfragment for this - this is bordering a
breaking change and will want to make sure we message it appropriately.
I'm not very familiar with how `newsfragments` work. Would you mind
explaining this in a bit more detail? I want to make sure I follow the correct
process, especially since this change is close to being a breaking one.
Thanks again for your guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
