kaxil commented on code in PR #52597:
URL: https://github.com/apache/airflow/pull/52597#discussion_r2176582986
##########
providers/redis/src/airflow/providers/redis/version_compat.py:
##########
@@ -33,3 +33,11 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk import BaseOperator, BaseSensorOperator
+else:
+ from airflow.models import BaseOperator
+ from airflow.sensors.base import BaseSensorOperator # type:
ignore[no-redef]
+
+__all__ = ["AIRFLOW_V_3_0_PLUS", "BaseOperator", "BaseSensorOperator"]
Review Comment:
Yeah, we still need it in `__all__` or we need to re-export them. Without
that, ruff will remove those imports when you run:
```
pre-commit run ruff --all-files; pre-commit run ruff-format --all-files
```
and change it to:
```
if AIRFLOW_V_3_0_PLUS:
pass
else:
pass # type: ignore[no-redef]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
